-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release/10.0.1xx] Track mono aot in telemetry too #50864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.1xx
Are you sure you want to change the base?
Conversation
cc @danroth27 |
/cc @matouskozak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to add interpreter tracking as well or is it enough to track AOT for WASM and consider that interpreter is used when RunAotCompiliaton=false
? Not sure what are all the possible configurations for WASM...
FYI: In Workload telemetry there is:
Lines 35 to 37 in 73c9295
<_WorkloadUsesInterpreter>$(MonoForceInterpreter)</_WorkloadUsesInterpreter> | |
<_WorkloadUsesInterpreter Condition="'$(_WorkloadUsesInterpreter)' == '' and '$(UseInterpreter)' == 'true'">true</_WorkloadUsesInterpreter> | |
<_WorkloadUsesInterpreter Condition="'$(_WorkloadUsesInterpreter)' == '' and '$(RunAOTCompilation)' != 'true' and ('$(_WorkloadUsesBlazorWasm)' == 'true' or '$(_WorkloadUsesWasmSDK)' == 'true')">true</_WorkloadUsesInterpreter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds telemetry tracking for the RunAOTCompilation
property to monitor Ahead-Of-Time compilation usage alongside existing AOT-related telemetry. The changes ensure that mono AOT compilation scenarios are now captured in diagnostic data.
- Added
RunAOTCompilation
to the target framework telemetry collection - Updated test infrastructure to include the new telemetry parameter in JSON generation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets | Added RunAOTCompilation property to TFTelemetry collection |
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreAppForTelemetry.cs | Updated telemetry JSON generation method to include runAotCompilation parameter |
This pull request adds support for collecting telemetry on the
RunAOTCompilation
property in both the build targets and the associated telemetry tests. The changes ensure that the value ofRunAOTCompilation
is now tracked and included in telemetry output, which will help with diagnostics and analytics related to Ahead-Of-Time (AOT) compilation.Telemetry enhancements:
TFTelemetry
item forRunAOTCompilation
in theMicrosoft.NET.TargetFrameworkInference.targets
file to capture its value during builds.CreateTargetFrameworkEvalTelemetryJson
method inGivenThatWeWantToBuildANetCoreAppForTelemetry.cs
to include therunAotCompilation
parameter and property in the generated telemetry JSON.