-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Convert numeric telemetry parameters to measurements for better analytics #51071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert numeric telemetry parameters to measurements for better analytics #51071
Conversation
Approved over email - failing tests should just be the GenerateBundle known issue. @marcpopMSFT / @MiYanni can either of you merge on red? |
/ba-g GenerateBundle known issue with a fix on the way. |
Co-authored-by: baronfel <[email protected]>
6205642
to
5c69c4d
Compare
@marcpopMSFT / @MiYanni can I get a merge on red for this one? it's approved and stuck on the generatebundle known issue stuff. Alternatively if we implement @nagilson's check then I can stop bugging y'all. |
@baronfel One of the failures looks like it may be a different issue:
@nagilson I saw this on another PR, do you know what that one is? |
@dsplaisted that's this known issue: #51049, I think @nagilson's poked some folks about relatively recent changes in Targets files that are causing this. |
That's fixed, but it cant be merged because generate asset bundles is still failing. If you may please update the repo config so we can merge with known issues then that fix can be merged #51084 |
Alternatively, someone could grant me admin rights on the sdk repo 🥺 |
Two different known issues, merging as it's approved |
Changes
This PR converts numeric telemetry parameters in
RunTelemetry.TrackRunEvent
from string properties to numeric measurements, enabling easier numeric comparisons and aggregations on the backend. Thanks to @DamianEdwards for seeing this!Risk
Low - just changes telemetry upload patterns
Testing
tests that verify the data is flowing through the telemetry system were updated
Copilot details
What changed
The following parameters are now sent as measurements (doubles) instead of properties (strings):
sdk_count
package_reference_count
project_reference_count
additional_properties_count
(file-based apps only)Why
Telemetry measurements are specifically designed for numeric data and enable the backend analytics system to perform:
sdk_count > 1
)Previously, these values were stored as string properties, which required string-to-number conversion on the backend and limited the types of analysis that could be performed efficiently.
Example
Before:
After:
Testing
All existing tests have been updated to verify that numeric values are now sent in the measurements dictionary instead of the properties dictionary. All 11 RunTelemetry tests pass successfully.
Fixes #<issue_number>
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the
docs.