Fix build breaks #200
Merged
Fix build breaks #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have the net47 targeting pack installed so I was getting build warnings/errors. Adding a package reference to `Microsoft.NETFramework.ReferenceAssemblies` allows this to build with fewer preinstalled dependencies.
|
Thanks for this. Is the 47 packageref needed as what we need are the tools from the net 4.8 directory: https://github.com/dotnet/SignService/blob/master/src/SignService/SignService.csproj#L20 |
|
No. The ReferenceAssemblies package ref is needed for this: |
|
Ah, right forgot. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement of installing the net47 targeting pack, and adds the missing package reference for accessing the registry in .NET Core.
Fixes #199