-
Notifications
You must be signed in to change notification settings - Fork 66
Add CollectionBuilderAttribute to System.Collections.Immutable #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mthalman
merged 2 commits into
dotnet:main
from
ericstj:immutableCollections-CollectionBuilder
Jan 23, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
...ncePackages/src/system.collections.immutable/8.0.0/System.Collections.Immutable.Manual.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
// ------------------------------------------------------------------------------ | ||
// Changes to this file must follow the http://aka.ms/api-review process. | ||
// ------------------------------------------------------------------------------ | ||
|
||
// See https://github.com/dotnet/sdk/issues/33693 for why this is necessary. | ||
|
||
namespace System.Collections.Immutable | ||
{ | ||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableList), "Create")] | ||
public partial interface IImmutableList<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableQueue), "Create")] | ||
public partial interface IImmutableQueue<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableHashSet), "Create")] | ||
public partial interface IImmutableSet<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableStack), "Create")] | ||
public partial interface IImmutableStack<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableArray), "Create")] | ||
public readonly partial struct ImmutableArray<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableHashSet), "Create")] | ||
public sealed partial class ImmutableHashSet<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableList), "Create")] | ||
public sealed partial class ImmutableList<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableQueue), "Create")] | ||
public sealed partial class ImmutableQueue<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableSortedSet), "Create")] | ||
public sealed partial class ImmutableSortedSet<T> | ||
{} | ||
|
||
[Runtime.CompilerServices.CollectionBuilder(typeof(ImmutableStack), "Create")] | ||
public sealed partial class ImmutableStack<T> | ||
{} | ||
} | ||
|
||
namespace System.Runtime.CompilerServices | ||
{ | ||
internal sealed class CollectionBuilderAttribute(Type builderType, string methodName) : Attribute | ||
{ | ||
public Type BuilderType { get; } = builderType; | ||
|
||
public string MethodName { get; } = methodName; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.