RHEL/CentOS 8 missing net46/Microsoft.NET.Sdk.Razor.Tasks.dll

[michaelbarkdoll]

Hi, I have an issue with a missing .dll file.

My C# extension no longer loads in VS Code due to this missing dll.

dotnet/vscode-csharp#4360

On the Ubuntu 20.04 LTS the dotnet-sdk-5.0 package has the following dll files:
/usr/share/dotnet/sdk/5.0.102/Sdks/Microsoft.NET.Sdk.Razor/tasks/net46/Microsoft.NET.Sdk.Razor.Tasks.dll
/usr/share/dotnet/sdk/5.0.102/Sdks/Microsoft.NET.Sdk.Razor/tasks/net5.0/Microsoft.NET.Sdk.Razor.Tasks.dll

However, my CentOS 8 only has the following file installed after upgrading to 5.0.102:
/usr/lib64/dotnet/sdk/5.0.102/Sdks/Microsoft.NET.Sdk.Razor/tasks/net5.0/Microsoft.NET.Sdk.Razor.Tasks.dll

So it appears that in RHEL/CentOS 8 the following file(s) are missing:
/usr/lib64/dotnet/sdk/5.0.102/Sdks/Microsoft.NET.Sdk.Razor/tasks/net46/Microsoft.NET.Sdk.Razor.Tasks.dll

ls -la tasks/net46/
-rw-r--r-- 1 root root 77192 Dec 14 20:17 Microsoft.NET.Sdk.Razor.Tasks.dll
-rw-r--r-- 1 root root 189832 Dec 14 20:17 System.Collections.Immutable.dll
-rw-r--r-- 1 root root 464776 Dec 14 20:17 System.Reflection.Metadata.dll

[dagood]

For context: CentOS builds .NET from source, based on the infrastructure in this repo dotnet/source-build. That's why it's different from the build produced by Microsoft.

We currently have a patch that removes the net46 build for this part of the SDK, so we'll have to look into removing the patch to build the net46 files. https://github.com/dotnet/source-build/blob/release/5.0/patches/aspnetcore/0010-Don-t-build-for-full-fx.patch. (It's not new to 5.0.102, it was in 5.0.100 as well: https://github.com/dotnet/source-build/blob/v5.0.100-SDK/patches/aspnetcore/0012-Don-t-build-for-full-fx.patch.)
@crummel do you happen to know why this patch was needed?

/cc @omajid (FWIW, the test script at #1950 seems to work fine with CentOS 8's 5.0.102.)

[omajid]

@omajid (FWIW, the test script at #1950 seems to work fine with CentOS 8's 5.0.102.)

I took a quick look and it looks like that script only tries out a dotnet new console project, which works with omnisharp. Many other project types (for example, web, blazorserver) don't.

[dagood]

We got an error message from #2008 showing what the patch was avoiding:

Based on this error:

/src/artifacts/src/aspnetcore.2670c128d522473e146ff9f8159bfffdfe694cd9/src/Razor/Microsoft.NET.Sdk.Razor/src/Microsoft.NET.Sdk.Razor.csproj : error NU1202: Package Microsoft.Build.Framework 16.8.3 is not compatible with net46 (.NETFramework,Version=v4.6). Package Microsoft.Build.Framework 16.8.3 supports: netstandard2.0 (.NETStandard,Version=v2.0) [/src/.dotnet/sdk/5.0.100/NuGet.targets]

I would guess we need to get rid of this DotNetBuildFromSource condition:

https://github.com/dotnet/msbuild/blob/39993bd9d02917993b6147a9973dc3aa6e9b00c7/src/Directory.Build.props#L29-L30

    <LibraryTargetFrameworks>$(FullFrameworkTFM);netstandard2.0</LibraryTargetFrameworks>
    <LibraryTargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">netstandard2.0</LibraryTargetFrameworks>

[tvildo]

On Centos 33 Omnisharp was crashing with exception and to solve that I had to install additional package:
dotnet add package Microsoft.NET.Sdk.Razor --version 3.1.12

[omajid]

Hey folks. Any progress on this? Is there anything I can do to help here?