-
Notifications
You must be signed in to change notification settings - Fork 136
Enable building allConfigurations for corefx in source-build #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
When we enable this we need to take into account #184 |
@bartonjs this is likely something we will need to do at some point to fully build the packages people depend on upstack. |
Status: I worked on this for a while. I'm able to make CoreFX build AllConfigurations on linux after a few changes. WIP branch: master...dagood:corefx-all Initially I tried to use a single command to build The build passes with AllConfigurations included, but it brings in a ton of new prebuilts: 68c0578. Main categories are:
I experimented with forcing them to be treated as reference packages, but hit problems with resource files in the ILDasm/ILAsm round trip. |
Fixed with #1173 |
Uh oh!
There was an error while loading. Please reload this page.
We need to build all packages not just .NET Core app packages when we are in offline source-build mode. However the allconfigurations leg has never worked correctly on non-windows so we need to iterate on it in order to enable.
We need to essentially undo 617ebe0.
The text was updated successfully, but these errors were encountered: