Offline VMR builds failing in arcade

[mthalman]

##[error]/vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj(0,0): error NU1603: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Microsoft.DotNet.Build.Tasks.Packaging depends on Microsoft.Extensions.FileProviders.Abstractions (>= 8.0.0-preview.4.23259.5) but Microsoft.Extensions.FileProviders.Abstractions 8.0.0-preview.4.23259.5 was not found. An approximate best match of Microsoft.Extensions.FileProviders.Abstractions 8.0.0-rc.2.23475.17 was resolved.

This is a regression that showed up in https://github.com/dotnet/dotnet/compare/3b48d00b46430d73172ea5f70b2e1569a2235925..cbb3431e4c65760b8e8bd3e1c8d3cd9be861897d

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[mthalman]

This seems to be caused by the removal of a NoWarn for NU1603 in dotnet/installer#17712

[mthalman]

It'd be good to understand why this isn't caught in the online builds and whether we need to reintroduce an offline leg in PR builds.

[MichaelSimons]

It'd be good to understand why this isn't caught in the online builds and whether we need to reintroduce an offline leg in PR builds.

It was detected as a prebuild. The problem is that the online prebuilts check was disabled because there are currently prebuilts.

[mthalman]

Yeah, it might be good to have offline builds turned back on until we can eliminate the prebuilts.

[NikolaMilosavljevic]

This is odd. I've validated full set of VMR builds, although that was done for release/8.0.1xx: https://dev.azure.com/dnceng/internal/_build/results?buildId=2309593&view=results

[mthalman]

That's because this dependency was only added to the main branch in arcade, not release/8.0.

[NikolaMilosavljevic]

Would it make most sense to introduce the patch for Arcade? I'd be hesitant to reintroduce global nowarns.

[NikolaMilosavljevic]

This was introduced by dotnet/arcade#14159, which added two new package dependencies, but did not update Version.Details.xml.

The fix is simple - add the following to arcade's Version.Details.xml:

    <Dependency Name="Microsoft.Extensions.FileProviders.Abstractions" Version="8.0.0-preview.4.23259.5">
      <Uri>https://github.com/dotnet/runtime</Uri>
      <Sha>547c506abe05e510bd43330fc8f6d4c5961e9223</Sha>
      <SourceBuild RepoName="runtime" ManagedOnly="false" />
    </Dependency>
    <Dependency Name="Microsoft.Extensions.FileSystemGlobbing" Version="8.0.0-preview.4.23259.5">
      <Uri>https://github.com/dotnet/runtime</Uri>
      <Sha>547c506abe05e510bd43330fc8f6d4c5961e9223</Sha>
      <SourceBuild RepoName="runtime" ManagedOnly="false" />
    </Dependency>

My local build has passed the failure point - waiting till completion.

Should we do a patch + Arcade PR, or just the Arcade PR?

[MichaelSimons]

I would just fix arcade. It flows quickly into installer.