[SBRP] System.Runtime.InteropServices references the wrong System.Reflection assembly

[ViktorHofer]

Repro: ./generate.sh --package System.IO.Pipelines,8.0.0
Observe changes in "src/referencePackages/src/system.runtime.interopservices/4.3.0/ref/netcoreapp1.1/System.Runtime.InteropServices.cs"

The GenAPI version used is a week old.

cc @ericstj

[ViktorHofer]

OK, this actually isn't a GenAPI bug but a wrong dependency being used for System.Runtime.InteropServices. It compiles against System.Reflection netstandard1.5 instead of netcore50 (because netcore50 is filtered out in SBRP). netcore50 doesn't have that abstract API.

This will show up again in SBRP every time someone transitively generates the compile source for System.Runtime.InteropServices.

[ViktorHofer]

@MichaelSimons looks like the removal of the netcore50 asset for System.Reflection broke this. I see a couple of options:

• Bring netcore50 for System.Reflection back
• Don't do anything and live with the delta. Document that the removal of the API should be undone. This is the worst option from a correctness standpoint as the API shouldn't be defined for netcoreapp1.1: https://apisof.net/catalog/daf24a6e-c08e-a231-1f13-f25206465b78
• Remove netcoreapp1.x assemblies from SBRP (my preferred option as this might affect other netcoreapp1.1 assemblies as well).

[ViktorHofer]

OK I need to take a closer look. Eric just corrected me that the netcore50 TFM should not be chosen by netcoreapp1.1.