Include the build location in README #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
A couple suggestions. Thanks, good place to have this info.
In theory https://github.com/dotnet/source-build/tree/release/3.1/Documentation is pointed to by the readme and has some of this, but it's quite out of date and doesn't really describe the mainline scenario. 😕
omajid
force-pushed
the
3.1-built-artifact-location
branch
from
19dfffb to
1bb6264
Compare
|
Thanks again. Merging disregarding CI, which I think should be disabled for this file. (Will be easier to check/fix that in the future with #1607.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users were asking about this on gitter channels. I figured it should be documented in the "obvious" location.
cc @dagood