Skip to content

Replace ASP.NET Core version-fix patch with source-mutation #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

omajid
Copy link
Member

@omajid omajid commented Jan 28, 2021

See: #1644

@dagood
Copy link
Member

dagood commented Jan 28, 2021

/azp run

Looks like the triggers are specified branch-by-branch in the AzDO pipeline... added release/* to try to break out of that. (And ultimately we should have it in the yaml.)

@azure-pipelines

This comment has been minimized.

@dagood
Copy link
Member

dagood commented Jan 28, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omajid
Copy link
Member Author

omajid commented Jan 29, 2021

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2005 in repo dotnet/source-build

@dagood
Copy link
Member

dagood commented Jan 29, 2021

Not sure why that would be... I hit retry though.

Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and the versions.props change is a good foundation for tarball/ci improvements.

@dagood dagood requested review from crummel and dseefeld January 29, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants