Skip to content

Conversation

suhsteve
Copy link
Member

@suhsteve suhsteve commented Oct 8, 2020

Add Microsoft.Spark 0.x to 1.0 migration guide.

Co-authored-by: Niharika Dutta <[email protected]>
@Niharikadutta
Copy link
Collaborator

Are we not mentioning the following:

  • Known issues: e.g.) grouped map UDF for Spark 3.0
  • .NET Delta/Hyperspace version | OSS Delta/Hyperspace version | Spark versions matrix
  • Dropping support for .NET Framework

@Niharikadutta
Copy link
Collaborator

Niharikadutta commented Oct 8, 2020

@imback82 Are we planning on adding scala version to the microsoft-spark*.jar filename?

@suhsteve
Copy link
Member Author

suhsteve commented Oct 8, 2020

Are we not mentioning the following:

  • Known issues: e.g.) grouped map UDF for Spark 3.0
  • .NET Delta/Hyperspace version | OSS Delta/Hyperspace version | Spark versions matrix
  • Dropping support for .NET Framework

The grouped map for 3.0 should go to the Release notes. Limited support for .NET Framework maybe the release notes as well ? Don't know if we need a delta/hyperspace matrix or not and where that should go.

@suhsteve
Copy link
Member Author

suhsteve commented Oct 8, 2020

@imback82 Are we planning on adding scala version to the microsoft-spark*.jar filename?

we can update release notes and this guide once the name is finalized.

@suhsteve suhsteve self-assigned this Oct 8, 2020
@suhsteve suhsteve added this to the 1.0.0 milestone Oct 8, 2020
imback82
imback82 previously approved these changes Oct 9, 2020
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except few minor comments, thanks @suhsteve!

@imback82
Copy link
Contributor

imback82 commented Oct 9, 2020

@imback82 Are we planning on adding scala version to the microsoft-spark*.jar filename?

we can update release notes and this guide once the name is finalized.

Sorry for the delay. I will sort this out tomorrow.

@imback82
Copy link
Contributor

imback82 commented Oct 9, 2020

Don't know if we need a delta/hyperspace matrix or not and where that should go.

Let's start putting this in the release notes similar to Spark versions supported.

@imback82
Copy link
Contributor

imback82 commented Oct 9, 2020

The naming for the JAR is finalized: #293. Can @suhsteve / @Niharikadutta help with updating any docs? Thanks!

@suhsteve
Copy link
Member Author

suhsteve commented Oct 9, 2020

The naming for the JAR is finalized: #293. Can @suhsteve / @Niharikadutta help with updating any docs? Thanks!

@imback82 I've updated the docs in the repo. #729

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @suhsteve!

@imback82 imback82 merged commit 21edf80 into dotnet:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants