findPath API Finds Extension Managed Runtimes #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It assumed that latestPatch and latestFeature could not be fulfilled if there was no patch requested by the user. But we should instead accept it. This would make '7.0.20' get rejected over '7.0' with 'latestPatch' which doesnt make sense because it should accept any later patch over the specified patch. In this case it was not specified so it should be accepted. Logic extracted out into another function was not changed.
nagilson
commented
May 28, 2025
| @@ -560,6 +560,21 @@ export function activate(vsCodeContext: vscode.ExtensionContext, extensionContex | |||
| } | |||
| } | |||
|
|
|||
| if (commandContext.acquireContext.mode === 'runtime' || commandContext.acquireContext.mode === 'aspnetcore') | |||
There was a problem hiding this comment.
Our SDKs are global, so they will be picked up by the existing logic.
nagilson
commented
May 28, 2025
vscode-dotnet-runtime-extension/src/test/functional/DotnetCoreAcquisitionExtension.test.ts
Outdated
Show resolved
Hide resolved
MiYanni
approved these changes
May 29, 2025
Comment on lines
+250
to
+252
| : | ||
| (() => | ||
| { |
There was a problem hiding this comment.
It is auto-formatted within the style guidelines set by the project, so in a way, yes..
even though I agree it looks ugly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our API was designed to find existing installs on the PATH, DOTNET_ROOT, VS Code settings, and or other places like in the registry / host install location.
However, it did not find the private runtimes that we had installed. This causes some extra work to be done when we could have re-use the existing installation according to what the API consumer wants, (they should specify a later version if using the findPath API.) Now consumers won't have to recall our acquire API for it to recognize it already installed something.