Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

Update implicit metapackage version for 2.2 apps #348

Merged
merged 6 commits into from
Jun 1, 2018

Conversation

natemcmaster
Copy link
Contributor

Changes:

  • merge latest release/2.1 changes
  • update the default and latest patch version selection to support netcoreapp2.2 projects

cc @dsplaisted @vijayrkn

@natemcmaster
Copy link
Contributor Author

@vijayrkn @seancpeters Windows builds fail with this. Any ideas?

2018-06-01T04:24:07.3280484Z E:\A\_work\3659\s>call "E:\A\_work\3659\s\\build\EnsureWebSdkEnv.cmd" 
2018-06-01T04:24:07.3288824Z Initializing web sdk environment
2018-06-01T04:24:07.3348332Z 'xcopy' is not recognized as an internal or external command,
2018-06-01T04:24:07.3348587Z operable program or batch file.

@vijayrkn
Copy link
Contributor

vijayrkn commented Jun 1, 2018

May be something changed in the build machines. Let me check.

@vijayrkn
Copy link
Contributor

vijayrkn commented Jun 1, 2018

@natemcmaster - Triggered another build this morning and this seems to work fine.

<DefaultPatchVersionForAspNetCoreAll2_1 Condition="'$(DefaultPatchVersionForAspNetCoreAll2_1)' == ''">2.1.1</DefaultPatchVersionForAspNetCoreAll2_1>
<DefaultPatchVersionForAspNetCoreApp2_1 Condition="'$(DefaultPatchVersionForAspNetCoreApp2_1)' == ''">2.1.1</DefaultPatchVersionForAspNetCoreApp2_1>

<LatestPatchVersionForAspNetCoreAll2_1 Condition="'$(LatestPatchVersionForAspNetCoreAll2_1)' == ''">2.1.*</LatestPatchVersionForAspNetCoreAll2_1>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsplaisted how do you plan to handle the latest patch version for NETCore.App 2.1.x in the 2.2 SDK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a hard-coded list of latest patch versions, and then tests which verify that those versions are correct so that we remember to keep them up-to-date. I'd recommend doing the same thing for the ASP.NET latest patch versions. dotnet/cli#9374 puts the default versions in the CLI, I would also add the latest versions and tests to make sure they're up-to-date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should do this. I've opened https://github.com/dotnet/cli/issues/9403 to follow-up on this.

<DefaultPatchVersionForAspNetCoreAll2_1 Condition="'$(DefaultPatchVersionForAspNetCoreAll2_1)' == ''">2.1.1</DefaultPatchVersionForAspNetCoreAll2_1>
<DefaultPatchVersionForAspNetCoreApp2_1 Condition="'$(DefaultPatchVersionForAspNetCoreApp2_1)' == ''">2.1.1</DefaultPatchVersionForAspNetCoreApp2_1>

<LatestPatchVersionForAspNetCoreAll2_1 Condition="'$(LatestPatchVersionForAspNetCoreAll2_1)' == ''">2.1.*</LatestPatchVersionForAspNetCoreAll2_1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a hard-coded list of latest patch versions, and then tests which verify that those versions are correct so that we remember to keep them up-to-date. I'd recommend doing the same thing for the ASP.NET latest patch versions. dotnet/cli#9374 puts the default versions in the CLI, I would also add the latest versions and tests to make sure they're up-to-date.

<PropertyGroup Condition="'$(DefaultPatchVersionForAspNetCoreAll2_2)' == ''">
<DefaultPatchVersionForAspNetCoreAll2_2>2.2.0</DefaultPatchVersionForAspNetCoreAll2_2>
<!-- Check the bundled version. It will start with 2.2.0 until create the final version of the 2.2.0 runtimes.-->
<DefaultPatchVersionForAspNetCoreAll2_2 Condition="$(BundledAspNetCoreAllPackageVersion.StartsWith('2.2.0'))">$(BundledAspNetCoreAllPackageVersion)</DefaultPatchVersionForAspNetCoreAll2_2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using a dash here (and in the below condition for AspNetCoreApp), as I did for dotnet/cli#9374. It's not needed here for correctness since we won't release an "01" patch version, but ensures that if we update the number or copy-paste it somewhere else it's more likely to be correct.

Nate McMaster added 2 commits June 1, 2018 15:40
@natemcmaster
Copy link
Contributor Author

Ok, thanks for the feedback @dsplaisted. I've updated this PR.

@natemcmaster
Copy link
Contributor Author

CI is passing now, thanks @vijayrkn. Are you okay with this change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants