[RC2/9.0] Backport Dark Mode fix #11929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add plausibility unit tests. Apply backwards-compatibility (10->9) fix. Refactor System-handling for SetColor. Fix XML comments and property value handling in Formxxx properties. Fix bug where in Visual Basic VisualStyles no longer get applied. Fix raising wrong event on changing FormCaptionTextColor.
lonitra
approved these changes
Aug 20, 2024
KlausLoeffelmann
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #11929 +/- ##
=====================================================
+ Coverage 74.72644% 74.80783% +0.08138%
=====================================================
Files 3019 3019
Lines 630034 630057 +23
Branches 46781 46783 +2
=====================================================
+ Hits 470802 471332 +530
+ Misses 155858 155352 -506
+ Partials 3374 3373 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KlausLoeffelmann
changed the title
dondr
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the Dark Mode Fix into .NET 9Rel.
The original bug fix (#11907) addressed a series of issues (#11910, #11898, #11897, #11895).
Since the original bug fix used Properties-APIs, which are not available in .NET 9RC/Rel, a few adjustments had to be made here. To further ensure stability, I added basic unit tests for dark mode.
Customer Impact
We introduced a new experimental Feature “Dark Mode”. This accidentally regressed VB Apps, which are no longer able to enable Visual Styles. This PR would also address a couple of minor issues in Dark Mode itself, which have been found in recent testing.
Workaround: For the VB Part, there is no easy workaround, since
Application.EnableVisualStylesis usually run in Program.cs, and in a VB App Framework App, there is no equivalent.The issues of the new features do not have a workaround, but they also did not exist before.
Regression?
Risk
Verification
Microsoft Reviewers: Open in CodeFlow