Scale the Cursor editor according to DPI #13830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
requested review from
Copilot and
JeremyKuhne
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper DPI scaling support to the Cursor editor in PropertyGrid to fix display issues on high DPI environments. The changes ensure the cursor editor renders correctly at different DPI scales by dynamically calculating dimensions instead of using hard-coded values.
- Replaces hard-coded height value with DPI-aware scaling
- Updates cursor rendering to use dynamically calculated width based on scaled icon size
- Adjusts text positioning to account for variable cursor width
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13830 +/- ##
===================================================
- Coverage 77.10728% 77.10643% -0.00085%
===================================================
Files 3273 3273
Lines 644882 644884 +2
Branches 47688 47689 +1
===================================================
- Hits 497251 497247 -4
- Misses 143958 143966 +8
+ Partials 3673 3671 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
added
the
waiting-review
|
Hey @LeafShi1, Could you also take a look at the Anchor Editor, if it is related and maybe fixable in the same way? It also looks terrible in certain HighDPI scenarios. Thanks! |
dotnet-policy-service
bot
removed
the
waiting-review
I submitted another PR #13853 for Anchor editor, please review it. |
LeafShi1
added a commit
that referenced
this pull request
Sep 24, 2025
<!-- Please read CONTRIBUTING.md before submitting a pull request --> Related #13830 ## Proposed changes - Update the `InitializeComponent` method to draw the Anchor Editor using the scaled size instead of hard-coding it. <!-- We are in TELL-MODE the following section must be completed --> ## Customer Impact - On High DPI environment, Anchor editor in propertyGrid can be scaled well ## Regression? - No ## Risk - Minimal <!-- end TELL-MODE --> ## Screenshots <!-- Remove this section if PR does not change UI --> ### Before In 300% DPI: <img width="1783" height="750" alt="image" src="https://github.com/user-attachments/assets/e7373f7c-db87-4b56-a370-b98e14da03aa" /> ### After In 300% DPI: <img width="1281" height="846" alt="image" src="https://github.com/user-attachments/assets/c5c7560a-fcf1-42ba-97a9-32ed69e01470" /> ## Test methodology <!-- How did you ensure quality? --> - Manually ## Test environment(s) <!-- Remove any that don't apply --> - .net 10.0.0-rc.1.25454.102 <!-- Mention language, UI scaling, or anything else that might be relevant --> ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13853)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9007
Proposed changes
OnDrawItemmethod to draw the cursor using the scaled width instead of hard-coding it.Customer Impact
Regression?
Risk
Screenshots
Before
On High DPI environment, cursor editor in propertyGrid is not scaled well
After
On High DPI environment, cursor editor in propertyGrid can be scaled normally
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow