Skip to content

Remove refs provided by Microsoft.NETCore.App.Ref targeting pack #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Remove refs provided by Microsoft.NETCore.App.Ref targeting pack #5127

merged 1 commit into from
Jun 18, 2021

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Jun 18, 2021 •
edited by ghost
Loading

Relates to dotnet/runtime#54147
Relates to dotnet/windowsdesktop#1747

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner June 18, 2021 02:31
@ghost ghost assigned RussKie Jun 18, 2021
@RussKie RussKie merged commit 9081d94 into dotnet:main Jun 18, 2021
@RussKie RussKie deleted the remove_redundant_refs branch June 18, 2021 07:37
@ghost ghost added this to the 6.0 Preview7 milestone Jun 18, 2021
@ViktorHofer
Copy link
Member

Microsoft.Win32.Registry.AccessControl isn't part of the Microsoft.NETCore.App.Ref targeting pack.

@RussKie
Copy link
Contributor Author

RussKie commented Jun 18, 2021 via email

ViktorHofer
ViktorHofer reviewed Jun 18, 2021
View reviewed changes
global.json
},
"sdk": {
"version": "6.0.100-preview.4.21255.9"
"version": "6.0.100-preview.6.21317.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why the sdk update was necessary? Isn't the runtime flowing through the VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it does. IIRC this is something that repos must do manually.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 18, 2021 •
edited
Loading

Opps… Thank you

Apparently you don't use Microsoft.Win32.Registry.AccessControl anywhere so you can probably keep the drop of the dependency. But please double check yourself. Also can you please update the Versions.props file to remove the versions that aren't used anymore? Thanks

WindowsDesktop though also did this and that change needs to be reverted (see discussion in dotnet/windowsdesktop#1747).

@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

+1 more reviewer

@dreddy-work dreddy-work dreddy-work approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
6.0 Preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @ViktorHofer @dreddy-work