Microsoft.Net.Sdk.WindowsDesktop missing Mifcrosoft.WinFx.props

[livarcocc]

It seems the latest package versions of Microsoft.Net.Sdk.WindowsDesktop are missing a few files, like Microsoft.WinFx.props and Microsoft.WinFx.targets and the tools folder.

We caught this because with these files missing it is not possible to build windows desktop apps.

I turned the tests for these off in core-sdk to unblock the flow of dependencies there and linked to this issue.

[rladuca]

The dependency project for WindowsDesktop doesn't seem to consume Microsoft.NET.Sdk.WindowsDesktop.

I don't have a full understanding of the WindowsDesktop repo off the top of my head, but I can take a look later on and see what comes from adding that dependency.

[rladuca]

Sorry, completely misread this at first. I'm not sure why those are missing, I'm going to check any changes into the packaging in this repo, this has nothing to do with the WindowsDesktop repo.

[rladuca]

I think the offending change was:

wpf/eng/WpfArcadeSdk/tools/ShippingProjects.props

Line 188 in 7937304

<RepoLocation Condition="'$(RepoLocation)' == '' And $(WindowsDesktopSdkProject.Contains('$(NormalizedMSBuildProjectName)'))">WindowsDesktopSdk</RepoLocation>

Normally, the repo location would have been overridden here (so PBT would package in Microsoft.NET.Sdk.WindowsDesktop) but the empty check stops this from happening, so PBT packages with the normal GitHub transport package.

[rladuca]

@livarcocc The next flow up the chain should have the appropriate props, etc.

[wli3]

@rladuca could you let me know when that flows is done?

[rladuca]

@wli3 Microsoft.NET.Sdk.WindowsDesktop version 5.0.0-alpha1.1.20056.2 is the fixed package.

The WindowsDesktop repo has taken flow from that change but the rolling build is stuck on publishing, re-running that now to see if it will pass.