Fix StylusPlugIn OnStylusDown/Move/Up invoked on UI thread and called out of order #11108
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11103
Main PR
Description
See #11103
The
stylusDevice.CriticalActiveSource
may be null. And thestylusDevice.CriticalActiveSource
will update frominputReport.InputSource
. So that we directly useinputReport.InputSource
will be safe and reasonable.This PR can not 100% fix the #11103 , but this PR can alleviate the problem.
Customer Impact
Fix the out of roder issues.
Regression
None.
Testing
Test pass in my touch device.
And I build and publish my version to NuGet: https://www.nuget.org/packages/dotnetCampus.WPF.Resource/6.0.4-alpha07-test10
Risk
Normal. As description says, the
stylusDevice.CriticalActiveSource
will update frominputReport.InputSource
in UI thread. We can directly useinputReport.InputSource
in Stylus Input thread safely.Microsoft Reviewers: Open in CodeFlow