Skip to content

Address CS0656 with latest compiler #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2024
Merged

Address CS0656 with latest compiler #9135

merged 2 commits into from
May 20, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented May 20, 2024 •
edited by dotnet-policy-service bot
Loading

The latest compiler fails to build WPF with

CSC : error CS0656: Missing compiler required member 'System.Runtime.InteropServices.MemoryMarshal.CreateReadOnlySpan' [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\System.Windows.Input.Manipulations\System.Windows.Input.Manipulations.csproj]
CSC : error CS0656: Missing compiler required member 'System.Runtime.InteropServices.MemoryMarshal.CreateReadOnlySpan' [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\UIAutomation\UIAutomationTypes\UIAutomationTypes.csproj]

Adding a reference to System.Memory to avoid this. I believe this is due to use of collection expressions taking advantage of this API

Microsoft Reviewers: Open in CodeFlow

@ericstj ericstj requested a review from a team as a code owner May 20, 2024 21:07
@ericstj ericstj mentioned this pull request May 20, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label May 20, 2024
@ericstj ericstj requested review from 333fred and jozkee May 20, 2024 21:47
@ericstj ericstj merged commit d6b1f45 into main May 20, 2024
@ericstj ericstj deleted the ericstj-system-memory-CS0656 branch May 20, 2024 21:50
@ericstj
Copy link
Member Author

ericstj commented May 21, 2024

Looks like we need more than this. It's also failing in UIAutomationProvider. Will see about reproducing in a WPF build to make sure we get everything.

@ericstj ericstj mentioned this pull request May 21, 2024
Merged
ViktorHofer added a commit that referenced this pull request May 21, 2024
@ViktorHofer
Update UIAutomationProvider.csproj
395e4bc 
Backport patch from https://github.com/dotnet/sdk/pull/41014/files#diff-b3f41574d88498615901b535fcd320fa624f41166bdb5b774bb096df94733be9

Same as #9135
@ViktorHofer ViktorHofer mentioned this pull request May 21, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@333fred 333fred 333fred approved these changes

@jozkee jozkee jozkee approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@ericstj ericstj

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericstj @333fred @jozkee