Change _TestHelixAgentPool from 19H1 to RS5

[vatsan-madhavan]

Changing _TestHelixAgentPool from 19H1 to RS5 seems to bring down execution time in Helix to approx 15 mins.

https://dev.azure.com/dnceng/public/_build/results?buildId=226613&view=logs

Looks like the 19H1 pool may have been the reason our builds have been suffering from chronic timeouts, much like the ServerRS5 pool prior to that.

Fixes #952

[ghost]

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

@msftbot, require at least 1 sign off.

[ghost]

@msftbot, require approvals from any one of the following: @vatsan-madhavan, @rladuca, @SamBent, @stevenbrix, @ryalanms

[vatsan-madhavan]

This time RS5 seemed to complete quickly, but generic Win10 and Win7 took a lot of time.

I’m not sure what the right solution should be. @MattGal any suggestions?

[MattGal]

@vatsan-madhavan I'm observing that certain teams are doing work items that take 1.5+ hours EACH due to setting special environment variables for JIT stress and such; when these teams (i.e. coreCLR) run their tests on any given queue, that queue will be backed up a bit because of the slow running work items sent.

I'll try to identify the folks doing this and see if we can maybe not do this every PR, but for now the best solution is to have longer build timeouts; if you don't the work still gets done, but the build gets retried; this is only making the problem worse and not improving your speeds at all.

[vatsan-madhavan]

I'll try to identify the folks doing this and see if we can maybe not do this every PR, but for now the best solution is to have longer build timeouts;

Alright, we'll try to up our timeout to 120 mins for now. Is there a tracking issue we can follow to keep up? I'd really like to keep our build times not become arbitrarily long. Can we chat about the possibility of getting separate Helix queues for our team (perhaps shared with WinForms) maybe?

/cc @AdamYoblick

[AdamYoblick]

Definitely share with us, we’re all friendly over here 😊 From: Vatsan Madhavan <[email protected]> Sent: Monday, June 17, 2019 12:51 PM To: dotnet/wpf <[email protected]> Cc: Adam Yoblick <[email protected]>; Mention <[email protected]> Subject: Re: [dotnet/wpf] Change _TestHelixAgentPool from 19H1 to RS5 (#975) I'll try to identify the folks doing this and see if we can maybe not do this every PR, but for now the best solution is to have longer build timeouts; Alright, we'll try to up our timeout to 120 mins for now. Is there a tracking issue we can follow to keep up? I'd really like to keep our build times not become arbitrarily long. Can we chat about the possibility of getting separate Helix queues for our team (perhaps shared with WinForms) maybe? /cc @AdamYoblick<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAdamYoblick&data=02%7C01%7CAdam.Yoblick%40microsoft.com%7C0c83a5870af04da9a5ca08d6f34c550b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636963906500582475&sdata=HjU44jxlyRkyMqK0A%2BEJfY2ZMwnOKjvjiUfWouL3a%2Fo%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwpf%2Fpull%2F975%3Femail_source%3Dnotifications%26email_token%3DAHASVDKH36HFWTZ6USA5U3LP27FHRA5CNFSM4HYPRKXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX36ISI%23issuecomment-502785097&data=02%7C01%7CAdam.Yoblick%40microsoft.com%7C0c83a5870af04da9a5ca08d6f34c550b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636963906500582475&sdata=BkQjmaKSCrVeSE8CRay%2B6CZSsvhp8NIuSZgzJtDsWxk%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHASVDJBZ5KHBE3HTOWVW53P27FHRANCNFSM4HYPRKXA&data=02%7C01%7CAdam.Yoblick%40microsoft.com%7C0c83a5870af04da9a5ca08d6f34c550b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636963906500587465&sdata=rRGJlsNZ9TbbKnhpTz0XQyc0StqyD%2BiZfF%2FI8hXFZWs%3D&reserved=0>.

[vatsan-madhavan]

We will add back Win7 after Preview 7. For now, we will test RS5 only.

[ghost]

@msftbot, require at least 1 sign off.

[ghost]

@msftbot, require approvals from any one of the following: @vatsan-madhavan, @rladuca, @SamBent, @stevenbrix, @ryalanms