Skip to content

Close all tabs before quitting. #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Close all tabs before quitting. #1221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718bc4e
Close all tabs before quitting.
ilonatommy Jun 24, 2024
a64fa94
Add logging.
ilonatommy Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,19 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
token.WaitHandle.WaitOne();
}

driver.Quit(); // Firefox driver hangs if Quit is not issued.
// close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox
// https://github.com/dotnet/runtime/issues/101617
logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
while (driver.WindowHandles.Count > 1)
{
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Close(); //Close Tab
driver.SwitchTo().Window(driver.WindowHandles.Last());
}
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Quit(); // Firefox driver hangs if Quit is not issued.
driverService.Dispose();
driver.Dispose();
}
Expand Down