Skip to content

Use the same default transformer for HttpForwarder and the whole YARP #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2021
Merged

Use the same default transformer for HttpForwarder and the whole YARP #1246

merged 4 commits into from
Sep 16, 2021

Conversation

alnikola
Copy link
Contributor

Fixes #1093

@alnikola alnikola added this to the YARP RC1 milestone Sep 15, 2021
Tratcher
Tratcher approved these changes Sep 15, 2021
View reviewed changes
@Kahbazi
Copy link
Member

Kahbazi commented Sep 15, 2021

Does this also need to be updated?
https://github.com/microsoft/reverse-proxy/blob/6a7b4fe43a0d1136897aeba0f6bcf532657522e1/samples/ReverseProxy.Direct.Sample/README.md#L40

alnikola
alnikola commented Sep 15, 2021
View reviewed changes
@alnikola alnikola merged commit 5641f49 into dotnet:main Sep 16, 2021
@alnikola alnikola deleted the alnikola/1093-consist-heads-transforms branch September 16, 2021 07:58
@Tratcher Tratcher mentioned this pull request Oct 2, 2021
Closed
@garrettm-msft garrettm-msft mentioned this pull request Nov 24, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@Kahbazi Kahbazi Kahbazi approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 1.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Inconsistent header transforms defaults between YARP and Forwarder
3 participants
@alnikola @Kahbazi @Tratcher