Skip to content

Change I*MetricsConsumer to a single interface #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Change I*MetricsConsumer to a single interface #1295

merged 1 commit into from
Oct 19, 2021

Conversation

MihaZupan
Copy link
Member

Doing this now since it is a breaking API change.
Allows us to remove a bunch of boilerplate from the implementation.

public interface IMetricsConsumer<TMetrics>
{
    void OnMetrics(TMetrics previous, TMetrics current);
}

Any thoughts on previous/current vs oldMetrics/newMetrics

@MihaZupan MihaZupan added this to the YARP RC1 milestone Oct 18, 2021
@MihaZupan MihaZupan requested a review from Tratcher as a code owner October 18, 2021 19:54
Tratcher
Tratcher approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show it to the rest of the team tomorrow before merging.

@MihaZupan MihaZupan merged commit 0dffd50 into dotnet:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
Breaking-Change
Projects
None yet
Milestone
YARP 1.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaZupan @Tratcher