Crashes on node v12

[jaydp17]

In the below code we check for error.message to end with the customPath.

serverless-plugin-split-stacks/lib/migration-strategy/custom.js

Line 16 in 5332646

if (e.code !== 'MODULE_NOT_FOUND' || !e.message.endsWith(`'${customPath}'`)) {

But starting with node.js v12, for MODULE_NOT_FOUND errors the error message also includes the require stack (nodejs/node#25690), which breaks the expected behavior that we want.

// e.message before node v12
"Cannot find module '/<serviceDirectory>/stacks-map.js'"

// e.message in node v12
"Cannot find module '/<serviceDirectory>/stacks-map.js'
Require stack:
- /<serviceDirectory>/node_modules/serverless-plugin-split-stacks/lib/migration-strategy/custom.js
- /<serviceDirectory>/node_modules/serverless-plugin-split-stacks/lib/migrate-new-resources.js
- /<serviceDirectory>/node_modules/serverless-plugin-split-stacks/split-stacks.js
- /<serviceDirectory>/node_modules/serverless/lib/classes/PluginManager.js
- /<serviceDirectory>/node_modules/serverless/lib/Serverless.js
- /<serviceDirectory>/node_modules/serverless/lib/utils/autocomplete.js
- /<serviceDirectory>/node_modules/serverless/bin/serverless"

[johndww]

@dougmoscrop Is it possible to cut a release for this? I can't figure out how to include the fix in my deployment in package.json.

[dougmoscrop]

Whoops! I will publish a release now.

For future reference if you're in a pinch, you can use a github reference as a version in package.json:

"serverless-plugin-split-stacks": "github:dougmoscrop/serverless-plugin-split-stacks#tag-or-sha"

[johndww]

@dougmoscrop thanks very much! Good to know for the future.

[dougmoscrop]

Published 1.7.3 with the fix