Skip to content

Should KafkaAdmin be renamed to KafkaAdminClient? #1621

New issue
New issue
Closed
Closed
Should KafkaAdmin be renamed to KafkaAdminClient?#1621
Milestone
 
2.0
@jeffwidman

Description

@jeffwidman
jeffwidman
opened on Oct 29, 2018
Contributor

Should KafkaAdmin be renamed to KafkaAdminClient?

The Java world typically calls it the AdminClient. And I can visualize a world where Admin could refer to a user, an ACL flag governing whether an application has admin permissions, or this client.

Thoughts @dpkp / @tvoinarovskyi ?

Activity

jeffwidman
added this to the 2.0 milestone on Nov 19, 2018
jeffwidman

jeffwidman commented on Nov 19, 2018

@jeffwidman
jeffwidman
on Nov 19, 2018
ContributorAuthor

Any feedback @dpkp / @tvoinarovskyi ?

tvoinarovskyi

tvoinarovskyi commented on Nov 19, 2018

@tvoinarovskyi
tvoinarovskyi
on Nov 19, 2018
Collaborator

Yup, sure, that makes sense to me. Matches Java's name too.

dpkp

dpkp commented on Nov 20, 2018

@dpkp
dpkp
on Nov 20, 2018 via email
Owner
jeffwidman
mentioned this on Nov 20, 2018
jeffwidman
closed this as completedin #1652on Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jeffwidman@dpkp@tvoinarovskyi

        Issue actions
          Should `KafkaAdmin` be renamed to `KafkaAdminClient`? · Issue #1621 · dpkp/kafka-python