Skip to content

Force lz4 to disable Kafka-unsupported block linking when encoding #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Apr 19, 2018
Merged

Force lz4 to disable Kafka-unsupported block linking when encoding #1476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfcec5
Force lz4 to disable Kafka-unsupported block linking when encoding
mnito Apr 18, 2018
2e5de9c
Support independent blocks for earlier versions of python-lz4
mnito Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion kafka/codec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@

try:
import lz4.frame as lz4

def _lz4_compress(payload, **kwargs):
# Kafka does not support LZ4 dependent blocks
try:
# For lz4>=0.12.0
kwargs.pop('block_linked', None)
return lz4.compress(payload, block_linked=False, **kwargs)
except TypeError:
# For earlier versions of lz4
kwargs.pop('block_mode', None)
return lz4.compress(payload, block_mode=1, **kwargs)

except ImportError:
lz4 = None

Expand Down Expand Up @@ -202,7 +214,7 @@ def snappy_decode(payload):


if lz4:
lz4_encode = lz4.compress # pylint: disable-msg=no-member
lz4_encode = _lz4_compress # pylint: disable-msg=no-member
elif lz4f:
lz4_encode = lz4f.compressFrame # pylint: disable-msg=no-member
elif lz4framed:
Expand Down