feat: support formatting of languages embedded in tagged template literals (Rust API Only) #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kt3k
force-pushed
the
html_css_templates_2
branch
from
cf05f55 to
b527e1f
Compare
|
@dsherret I think now this is ready for review. PTAL when you have time |
|
@kt3k can you please open a PR to Deno with a Cargo patch pointing to this PR to test it end-to-end? |
|
Sure! |
|
Opened denoland/deno#29014 |
dsherret
changed the title
dsherret
approved these changes
Apr 25, 2025
kt3k
added a commit
to denoland/deno
that referenced
this pull request
Apr 29, 2025
This commit adds the formatting of CSS, HTML, and SQL which are embedded in
Tagged Template Literal strings. The embedded languages are detected by
the tag name of the literal.
```ts
// triggers CSS formatting
const Div = styled.div`
margin: 5px;
padding: ${padding}px;
`;
// triggers HTML formatting
document.body.innerHTML = html`
<main>
<h1>Hello ${name}!<h1>
</main>
`;
// triggers SQL formatting when `--unstable-sql` passed
const query = sql`
SELECT
${table}.${field}
FROM
${table};
`
```
See dprint/dprint-plugin-typescript#701 for more
details
does it mean this can be closed as resolved now? if so, do I need to configure anything to start using it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continued from #683
towards denoland/deno#26880
Updates from the above:
css,styled.foo, andstyled(Foo)tags for css,htmltag for html,sqltag for sql.dprint_placeholder_N_idfor the placeholders between quasis (The identifier is inspired by prettier implementation css html)malva(css),markup_fmt(html), anddprint-plugin-sql(sql) for testing.(Didn't add support of styled-jsx (
<style jsx>) as it seems less popular these days).remaining tasks:
references: