patch: spotify and apple-music backtrack conflicts with remote control and display optimizations #355
Conversation
This patch is related to the spr plugin remote option in which it was conflicting with the mac-player plugin in which it was displaying the osascript scripts from this plugin.
… spotify there was error of using the R keybind that was not working with spotify and leading to the issues of spotify not working well.
catting the cache file alot of times would leading to increased latency.
|
Warning Rate limit exceeded@iberniex has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes update the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
scripts/mac-player.sh (1)
202-202: Minor: treat option as boolean, not stringStoring the default as the string
"false"then comparing with"true"works but is fragile (case-sensitivity, typos, non-bool values). Consider normalising the option:REMOTE_ACCESS=$(get_tmux_option "@dracula-mac-player-remote" "false") [[ ${REMOTE_ACCESS,,} == true ]]This lowers the risk of mis-configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/mac-player.sh(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
scripts/mac-player.sh (1)
scripts/utils.sh (1)
get_tmux_option(3-12)
🔇 Additional comments (2)
scripts/mac-player.sh (2)
210-218: Good move: remote-control options now loaded only when neededPulling the key-binding options inside the
REMOTE_ACCESSguard avoids unnecessary look-ups and keeps the variable scope tight.
221-225: Cache update is now single-pass – niceStoring
trackStatusonce and slicing the cached value eliminates the double command-execution and removes an extra subshell. This is a simple but valuable optimisation.
This patch contains solutions to errors (which were caused by my bad coding):