Switch CI to Github Actions #125

deivid-rodriguez · 2020-12-13T18:30:40Z

Closes #124.
Fixes #129.

slonopotamus · 2020-12-14T09:54:58Z

.github/workflows/test.yml

@@ -6,6 +6,7 @@ on:
  push:
    branches:
      - master
+      - github_actions


Is there any reason to limit branches that run tests at all? It results in ugly hacks like what you had to do in this commit.

This is just because github actions is not yet enabled in this repository, otherwise CI would've run because of the pull_request event. The reason to limit branches is to avoid duplicate CI runs on pushes to pull requests.

Even after GitHub Actions is enabled, user might want to run tests before creating a PR.

Yes. This is maintainers preference. My preference is that users either open a WIP PR or modifiy the workflow temporarily, and avoid all the duplicate builds by default. Others may have other preference. It's no big deal, I can change this to whatever @drbrain prefers.

slonopotamus · 2020-12-14T10:05:31Z

For some reason, Windows builds pass in your branch even though there was an error in tests.

deivid-rodriguez · 2020-12-14T10:06:17Z

Yeah, bug in hoe-travis.

slonopotamus · 2020-12-14T10:08:03Z

Yeah, bug in hoe-travis.

I'm not sure. See my run. The only difference is that you combined rake travis:before -t + rake travis + rake travis:after -t in a single step, why I run each command as a separate step.

deivid-rodriguez · 2020-12-14T10:25:32Z

Right, that's because the default Windows shell doesn't seem to have an -e mode enabled (inmediately exit when a command fails), so your way is definitely safer on Windows. However, as you can see the rake travis:before -t step didn't fail in your run either and that's a bug in travis-hoe.

slonopotamus · 2020-12-14T10:36:40Z

I suggest splitting Windows CI into a separate PR. This is not a regression (net-http-persistent never had Windows CI before), but it severely increases amount of changes. And it might be that net-http-persistent test suite simply doesn't work on Windows and needs even more fixes.

slonopotamus · 2020-12-14T10:39:11Z

default Windows shell doesn't seem to have an -e mode enabled

Because it's PowerShell) However, run: workflow step allows to choose what shell to use.

deivid-rodriguez · 2020-12-14T10:42:04Z

Yeah, I splitted the tests like you did 👍.

I suggest splitting Windows CI into a separate PR. This is not a regression (net-http-persistent never had Windows CI before), but it severely increases amount of changes. And it might be that net-http-persistent test suite simply doesn't work on Windows and needs even more fixes.

Agreed, but I want to get everything working first. I can split it afterwards if maintainers prefer so. This repo is barely attended so I feel relying on many dependant PRs might make things slower and less likely to get attention 🤷‍♂️.

deivid-rodriguez · 2020-12-17T18:25:54Z

I managed to repro the issue, although I had to add a bunch of patches to dependent libraries. I guess I'll start by submitting patches upstream.

slonopotamus · 2020-12-17T19:29:30Z

That might take some time before upstream libs accept changes and make releases with them.

That's why I suggested splitting: travis-ci.org that is currently used for CI is going to stop existing on December, 31. So moving to a different CI has a value on its own.

deivid-rodriguez · 2020-12-17T19:33:51Z

Sure, I'm not saying no to your suggestion, I'm just waiting for some input from maintainers while working on reproducing and fixing the current issue in CI. As soon as maintainers tell me what they expect, I can quickly amend this PR :)

deivid-rodriguez · 2020-12-17T19:43:05Z

It's all green now, by the way https://github.com/deivid-rodriguez/net-http-persistent/runs/1572593796?check_suite_focus=true.

deivid-rodriguez · 2020-12-22T12:56:05Z

Made some progress here by completely getting rid of hoe-travis, which makes sense to me since we are migrating away from travis 😅

deivid-rodriguez · 2021-02-03T09:48:15Z

I didn't find time to follow up on this yet, but at least I created a WIP PR to hoe to see how maintainers there feel about my patches.

deivid-rodriguez · 2021-06-26T14:20:45Z

Both my PR and the PR to hoe adding a CI have been unattended for a while. Maybe an alternative would be to move away from hoe here. Although this PR itself has been unattended too, so I'm not really sure how to proceed.

petergoldstein · 2022-01-25T18:12:06Z

@deivid-rodriguez To keep this up to date, can you add '3.0' (note the quotes) and 3.1 to the CI matrix?

It doesn't seem necessary and we're moving away from TravisCI.

deivid-rodriguez · 2022-01-25T19:11:06Z

Done, hopefully this repository gets some love again.

It's easier to manage the `Gemfile` directly.

Changelog seems managed directly, and manifest is checked by `rake check_manifest`.

I don't see where it's used.

Same thing, but https.

I want to add a little gem to manage the Rakefile to replace Hoe (which does not support Windows). But this gem does not support Ruby 2.3. The easiest fix is to drop Ruby 2.3 support.

Instead, use explicit gemspec + `Rake::Manifest::Task` + `Rake::TestTask`.

deivid-rodriguez · 2022-02-09T11:45:36Z

Alright, I updated this PR so it doesn't depend on any fixes in Hoe.

Now it does the following:

Development Environment

Migrates CI to GitHub Actions.
Adds Windows & JRuby to CI.
Adds Ruby 3.0 and 3.1 to CI matrix.
Replaces Hoe with other tools that have no issues on Windows.

User facing changes

Drop support for Ruby 2.3 (could be fixed but rake-manifest which I used for managing the Manifest file needs that).
Restore JRuby + Windows support.

I'll set it as ready!

.github/workflows/test.yml

deivid-rodriguez · 2022-03-12T05:39:07Z

❤️

deivid-rodriguez mentioned this pull request Dec 13, 2020

resolves #124 migrate CI to GitHub Actions #126

Closed

slonopotamus reviewed Dec 14, 2020

View reviewed changes

deivid-rodriguez marked this pull request as draft December 14, 2020 21:24

deivid-rodriguez force-pushed the github_actions branch 2 times, most recently from d232761 to 8e317fc Compare December 22, 2020 12:49

deivid-rodriguez force-pushed the github_actions branch from 23b8a67 to 51f53a0 Compare December 22, 2020 13:14

gogainda mentioned this pull request Jan 8, 2021

Add Truffleruby head to CI #128

Open

This was referenced Feb 3, 2021

on windows jruby: getrlimit not supported on this platform #129

Closed

Support Jruby + Windows seattlerb/hoe#111

Closed

deivid-rodriguez mentioned this pull request Jan 25, 2022

Migrate to GitHub Actions for CI #135

Closed

Remove hoe-travis

cc5e0a9

It doesn't seem necessary and we're moving away from TravisCI.

deivid-rodriguez force-pushed the github_actions branch from 51f53a0 to dd68da9 Compare January 25, 2022 19:10

deivid-rodriguez added 2 commits February 9, 2022 10:50

Regenerate Gemfile

b4ab655

Remove hoe-bundler

db624ad

It's easier to manage the `Gemfile` directly.

deivid-rodriguez added 4 commits February 9, 2022 10:55

Remove hoe-git

e70eb4c

Changelog seems managed directly, and manifest is checked by `rake check_manifest`.

Remove hoe-minitest

6c09f86

I don't see where it's used.

Use rdoc.info for docs

cbba459

Same thing, but https.

Add missing gem to Gemfile

118b2b8

deivid-rodriguez force-pushed the github_actions branch 6 times, most recently from 94aa6ef to d2c3332 Compare February 9, 2022 11:34

deivid-rodriguez added 6 commits February 9, 2022 12:38

Drop Ruby 2.3 support

93cda41

I want to add a little gem to manage the Rakefile to replace Hoe (which does not support Windows). But this gem does not support Ruby 2.3. The easiest fix is to drop Ruby 2.3 support.

Replace hoe

3d29b2f

Instead, use explicit gemspec + `Rake::Manifest::Task` + `Rake::TestTask`.

Run tests with bundle exec

bc4efb1

Switch CI to Github Actions

9dd3732

Get specs passing on Windows & JRuby

0cab61c

Add Ruby 3.0 and 3.1 to CI matrix

32a63ce

deivid-rodriguez force-pushed the github_actions branch from d2c3332 to 32a63ce Compare February 9, 2022 11:42

deivid-rodriguez marked this pull request as ready for review February 9, 2022 11:45

simi reviewed Mar 10, 2022

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

Remove one last reference to Travis

53c64a0

drbrain merged commit 857c3ba into drbrain:master Mar 11, 2022

deivid-rodriguez deleted the github_actions branch March 12, 2022 05:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch CI to Github Actions #125

Switch CI to Github Actions #125

deivid-rodriguez commented Dec 13, 2020 •

edited

Loading

slonopotamus Dec 14, 2020

deivid-rodriguez Dec 14, 2020

slonopotamus Dec 14, 2020

deivid-rodriguez Dec 14, 2020

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020 •

edited

Loading

deivid-rodriguez commented Dec 17, 2020 •

edited

Loading

slonopotamus commented Dec 17, 2020

deivid-rodriguez commented Dec 17, 2020

deivid-rodriguez commented Dec 17, 2020

deivid-rodriguez commented Dec 22, 2020

deivid-rodriguez commented Feb 3, 2021

deivid-rodriguez commented Jun 26, 2021

petergoldstein commented Jan 25, 2022

deivid-rodriguez commented Jan 25, 2022

deivid-rodriguez commented Feb 9, 2022 •

edited

Loading

deivid-rodriguez commented Mar 12, 2022

Switch CI to Github Actions #125

Switch CI to Github Actions #125

Conversation

deivid-rodriguez commented Dec 13, 2020 • edited Loading

slonopotamus Dec 14, 2020

Choose a reason for hiding this comment

deivid-rodriguez Dec 14, 2020

Choose a reason for hiding this comment

slonopotamus Dec 14, 2020

Choose a reason for hiding this comment

deivid-rodriguez Dec 14, 2020

Choose a reason for hiding this comment

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

slonopotamus commented Dec 14, 2020

deivid-rodriguez commented Dec 14, 2020 • edited Loading

deivid-rodriguez commented Dec 17, 2020 • edited Loading

slonopotamus commented Dec 17, 2020

deivid-rodriguez commented Dec 17, 2020

deivid-rodriguez commented Dec 17, 2020

deivid-rodriguez commented Dec 22, 2020

deivid-rodriguez commented Feb 3, 2021

deivid-rodriguez commented Jun 26, 2021

petergoldstein commented Jan 25, 2022

deivid-rodriguez commented Jan 25, 2022

deivid-rodriguez commented Feb 9, 2022 • edited Loading

Development Environment

User facing changes

deivid-rodriguez commented Mar 12, 2022

deivid-rodriguez commented Dec 13, 2020 •

edited

Loading

deivid-rodriguez commented Dec 14, 2020 •

edited

Loading

deivid-rodriguez commented Dec 17, 2020 •

edited

Loading

deivid-rodriguez commented Feb 9, 2022 •

edited

Loading