fix: pass gitlab mergerequest param via json body #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Vernin <[email protected]>
1 task
olblak
added a commit
to olblak/updatecli
that referenced
this pull request
Aug 29, 2024
Use a fork of the drone/go-scm project until drone/go-scm#322 is merged and available. More information on updatecli#2429
olblak
added a commit
to olblak/updatecli
that referenced
this pull request
Aug 29, 2024
Use a fork of the drone/go-scm project until drone/go-scm#322 is merged and available. More information on updatecli#2429
olblak
added a commit
to updatecli/updatecli
that referenced
this pull request
Aug 29, 2024
* fix: gitlab token configuration Signed-off-by: Olblak <[email protected]> * fix: pass gitlab MR parameter via http body Use a fork of the drone/go-scm project until drone/go-scm#322 is merged and available. More information on #2429 --------- Signed-off-by: Olblak <[email protected]>
olblak
added a commit
to olblak/updatecli
that referenced
this pull request
Sep 3, 2024
* fix: gitlab token configuration Signed-off-by: Olblak <[email protected]> * fix: pass gitlab MR parameter via http body Use a fork of the drone/go-scm project until drone/go-scm#322 is merged and available. More information on updatecli#2429 --------- Signed-off-by: Olblak <[email protected]>
|
@abhinav-harness could you take a look at this pull request, as it fix a bug with the GitLab merge request creation |
abhinav-harness
approved these changes
Oct 7, 2024
|
@abhinav-harness Would it be possible to have this pullrequest available in a futur release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a merge request on GitLab, the current implementation pass all the parameters via the URL parameters instead of using the HTTP body.
The problem is that the amount of information that can be provided via URL parameter is very limited, which lead to not being able to create a merge request.
Test
On top of the unit test, I tested this change on a different project:
Screenshot
Additional Information
Potential improvement
I also noticed that function
CreateCommentuse URL parameter and I think it could also be improved but I am not using that function on my project