feat: [PIPE-29374]: make author/committer fields optional for GitHub App signed commits #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make author/committer fields optional for GitHub App signed commits
Overview
This PR modifies the GitHub driver in go-scm to make author and committer fields optional when using GitHub App authentication for commits. This change enables automatic commit signing by GitHub Apps without requiring explicit signature information.
Problem
Ticket : https://harness.atlassian.net/browse/PIPE-29374
When using GitHub App authentication, commits can be automatically signed by GitHub without providing explicit author/committer information. However, the current implementation in go-scm always includes these fields in the request payload, which prevents GitHub from automatically signing the commits.
Solution
This PR modifies the content service in the GitHub driver to:
Changes
contentService.Create()
to omit author/committer fields when signature is emptycontentService.Update()
to omit author/committer fields when signature is emptycontentService.Delete()
to omit author/committer fields when signature is emptyTesting
Screenshot
Screen.Recording.2025-08-21.at.7.09.10.PM.mov