-
Notifications
You must be signed in to change notification settings - Fork 19
Fix version constrains, support multiple stable branches. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the result. |
New files, with fixed logic for contrib. |
LGTM. We plan to merge this when next Drush release happens. |
It would very helpful if we could merge this into a new |
This PR is now publishing to the following branches. Thanks @webflo |
|
||
public static function handleCore($version) { | ||
list($major, $minor) = explode('.', $version); | ||
return ">=$major.$minor,<$version"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For D7, this returns constraints like >7.67,<=7.67
instead of >7,<=7.67
, so a different return is needed
public static function handleCore($version) {
list($major, $minor) = explode('.', $version);
if ($major == '7') {
return ">=$major,<$version";
}
return ">=$major.$minor,<$version";
}
Created branch build-v2 with this code and configured Circle CI similar to the master branch. https://github.com/drupal-composer/drupal-security-advisories/tree/build-v2 The build was successful a few minutes ago. @gapple Pleas open a new issue for D7 builds with v2 Version scheme. |
Related to drush-ops/drush#3748 (comment)