-
Notifications
You must be signed in to change notification settings - Fork 6
Update fork to our dependencies #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good on my end! Tested building and serving this branch out via:
composer create-project pattern-lab/edition-twig-standard:dev-feature/update-fork --repository '{ "type": "vcs", "url": "https://github.com/drupal-pattern-lab/edition-php-twig-standard" }' your-project-name && cd $_ && php core/console --generate
php core/console --server
As an open question to everyone before we merge though, should we:
A. Include a forked version of styleguidekit-assets-default directly here and remove the dependency from https://github.com/drupal-pattern-lab/styleguidekit-twig-default/blob/master/composer.json? (my personal recommendation)
B. Update our forked https://github.com/drupal-pattern-lab/styleguidekit-twig-default/blob/master/composer.json to point at a separate fork of styleguidekit-assets-default (which, imho, doesn't make sense as a dependency since styleguidekit-assets-default is template engine agnostic)
C. Leave it as is - which I'd recommend against given the 20 open issues and 3 open PRs...
I think C as We could always fork and contribute later if we saw reasons. |
OK, we've got comments on this in a couple places; but whatever: let's do it. Then it's less confusing as all pieces are our forks. |
…eguidekit-assets Add Styleguidekit Assets Fork
This points the main dependencies to our forks, and alters the readme's
composer create-project
command to use our stuff while side-stepping Packagist (for now), and adds Travis tests.