Skip to content

Conversation

nbcraft
Copy link

@nbcraft nbcraft commented Oct 3, 2022

This PR fixes the callable! check which was not raising when setting default: false, even though it does when setting default: true.

⚠️ This is a breaking change! As it will break for everyone who has set default: false in the past.

  • I believe this should trigger a major version bump because of it.
  • Not sure if I need to update changelog and version number myself, lmk and I'll update this PR.

(Note: I re-used some of @skryukov code from #93 for specs shared_examples)

@nbcraft nbcraft requested a review from solnic as a code owner October 3, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant