Split format and format_finite #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
reviewed
Jun 11, 2019
| fn is_nonfinite(self) -> bool { | ||
| const EXP_MASK: u64 = 0x7ff0000000000000; | ||
| let bits = unsafe { mem::transmute::<f64, u64>(self) }; | ||
| bits & EXP_MASK == EXP_MASK |
There was a problem hiding this comment.
Interesting. Does this wind up being faster than !number.f64::is_finite()?
Also, thanks so much for this! :-)
There was a problem hiding this comment.
Two things:
-
Until Add inherent methods in libcore for [T], [u8], str, f32, and f64 rust-lang/rust#49896, that method is std-only. We support no_std and older compilers than that.
-
The implementation here is the same speed on 1.34+ but substantially faster than f64::is_finite on older compilers which don't have Optimise floating point
is_finite(2x) andis_infinite(1.6x). rust-lang/rust#57353.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames buffer.format(f) to buffer.format_finite(f). Adds buffer.format(f) which can emit "NaN", "inf", "-inf" to match std::fmt.
Fixes #12.