Skip to content

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Sep 15, 2025

This has annoyed me for some time, needing to remember the filter pushdown logic is defined in arrow_array_stream.cpp which is completely illogical

Cleaned it up, added a Makefile for make format-main, and extended the import cache to get rid of some raw py::_module::import calls

@evertlammerts
Copy link
Collaborator

Ha, love it, frustration driven cleanup, go for it :-)

Re Makefile: I have a relatively strong preference to not have one here unless we must, and then not one that depends on scripts in the duckdb submodule. I have a branch where I'm adding the linting and formatting rules. I'm planning to add pre-commit there to run all clang-format and clang-tidy stuff. That integrates nicely with git workflows and CI. I'm hoping to merge this post the 1.4.0 release.

@Tishj
Copy link
Collaborator Author

Tishj commented Sep 15, 2025

Sure, using a Makefile is kind of "the duckdb way", so not having one entirely is kind of creating friction for duckdb maintainers to come in and contribute here, which is something to be aware of

But I'll rip it out for now

@evertlammerts evertlammerts added this pull request to the merge queue Sep 17, 2025
Merged via the queue into duckdb:v1.4-andium with commit 7a70392 Sep 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants