Correctly use earlephilhower.varant if variant not given, ensure USB… #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… power macro is always there
Fixes a crash of the builder script, `board.get("build.variant", None)` will throw an exception if the `build.variant` was not found (and not return `None` as the fallback value), but an empty string works, so check against that.
USB power defines moved directly into the board files, but still ensure that the macro always exists (with a default fallback value) to not fail the build.
|
I believe there's still a pico-quick-toolchain bug or PR left to fully close this stuff out, yes? |
You mean in regards to developing the PlatformIO further so that it is ready to merge into mainline PlatformIO / platform-raspberrypi? Yes, the whole packaging for toolchain-pico, tool-openocd-raspberry and framework-arduinopico is yet to be done. Either manually in the first round to get them in now or automated. The released OpenOCD package still has some issues on Windows (https://github.com/earlephilhower/pico-quick-toolchain/issues) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… power macro is always there
Cherry-pick of maxgerhardt@beec911
Fixes a crash of the builder script,
board.get("build.variant", None)will throw an exception if thebuild.variantwas not found (and not returnNoneas the fallback value which was the wanted behavior), but an empty string works, so check against that.USB power defines moved directly into the board files, but still ensure that the macro always exists (with a default fallback value) to not fail the build.