Skip to content

Conversation

carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented May 17, 2025

Fixes #3600

  • Needs some UI guidance by @manuelmeister
  • also allow filtering storycontext and safetyconsiderations
  • add a filter by day, to allow for inserting blank notes pages or other things in between program days

image

Ideas for the future (as long as this is not reviewed, I might continue working on some of these):

  • e2e test (hard because we can't test the contents of the pdfs yet)
  • display a prose summary of the active filter (hard because of the way the filter UI components are built right now)
  • allow to exclude a specific schedule entry (e.g. for perfectionists who want to hide the repeated schedule entries of the same activity, or for combined camps of Wolfsstufe and Pfadistufe, to print only the programme relevant for one Stufe)
  • filter content nodes inside the printed activities (e.g. exclude notes) (quite clearly a different feature)

@carlobeltrame carlobeltrame requested review from a team and manuelmeister May 17, 2025 10:27
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label May 17, 2025
@github-actions
Copy link

github-actions bot commented May 17, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame added deploy! Creates a feature branch deployment for this PR and removed deploy! Creates a feature branch deployment for this PR labels May 17, 2025
@carlobeltrame carlobeltrame added deploy! Creates a feature branch deployment for this PR and removed deploy! Creates a feature branch deployment for this PR labels May 17, 2025
@carlobeltrame carlobeltrame force-pushed the print-activity-filters branch from a1b3ccb to f6c2480 Compare May 17, 2025 14:50
@manuelmeister
Copy link
Member

Nice! My first reactions:

  • As a user I want to see some feedback/impact of the filters. Maybe a simple result count could be enough for the mvp (already in the dialog).
    Bildschirmfoto 2025-05-18 um 18 01 53

  • The button on the "page" should probably be aligned at the bottom and the same button style as the actual filters on the dashboard/picasso. Also with correct active state.
    Bildschirmfoto 2025-05-18 um 17 57 45

  • Also the button could be like: Filter YY activities (and if filtered then Filter: XX of YY activites or as you described: Filter: Kategorie & Status (XX) or Filter: LA und LS (XX) if only category filter is active)

  • Additional filters/modifiers would be cool eventually and could perfectly fit in the dialog (just bikeshedding: hide empty activites, prevent printing activity fully for every schedule entry, …)

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I click on filter on the PagesConfig, each schedule entry gets loaded individually.

@carlobeltrame
Copy link
Member Author

If I click on filter on the PagesConfig, each schedule entry gets loaded individually.

Fixed in a64bb23

@manuelmeister manuelmeister requested a review from a team May 30, 2025 16:12
@carlobeltrame carlobeltrame force-pushed the print-activity-filters branch from 6b60ff5 to 57956d3 Compare June 5, 2025 01:55
carlobeltrame and others added 12 commits June 5, 2025 21:40
@simfeld simfeld added this pull request to the merge queue Jun 10, 2025
Merged via the queue into ecamp:devel with commit 273367a Jun 10, 2025
30 checks passed
@carlobeltrame carlobeltrame deleted the print-activity-filters branch June 10, 2025 18:12
@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print activities by category

4 participants