-
Notifications
You must be signed in to change notification settings - Fork 170
Fix heading levels and reorganize "Creating a workspace from code sample" #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heading levels and reorganize "Creating a workspace from code sample" #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themr0c, in order to get {{site.baseurl}}
to resolve in included files, they need to have :page-liquid:
as the first line. Apologies for the confusion.
Please, update from master and apply this gimmick to your PR.
@@ -9,6 +9,7 @@ entries: | |||
url: che-7/introduction-to-eclipse-che | |||
output: web | |||
- title: Che quick-starts | |||
url: che-7/che-quick-starts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themr0c, this doesn't work. Can't be used.
url: che-7/che-quick-starts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the fact that src/main/pages/che-7/overview/assembly_che-quick-starts.adoc has the necessary for that page to be generated, it works. And it would be very useful to point the user to a landing page for the quick starts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themr0c what I mean is that when you click this menu item in the navig sidebar, it won't open the page, even though it will be built. (Navig items that expand to reveal other items can't open their own page.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themr0c OK, I see now that you changed the navig structure, and the 'Che quick starts' item no longer expand -- instead, it opens its own page. Please, don't change thing like that without consulting it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
[discrete] | ||
== Prerequisites | ||
|
||
* A running instance of Eclipse Che. To install an instance of Eclipse Che see link:../che-quick-starts[Che quick-starts]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* A running instance of Eclipse Che. To install an instance of Eclipse Che see link:../che-quick-starts[Che quick-starts]. | |
* A running instance of Eclipse Che. To install an instance of Eclipse Che see link:{{site.baseurl}}/che-7/che-quick-starts[Che quick-starts]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themr0c, please, use the {{site.baseurl}}
var for links. This relative inking isn't portable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, no, just {site-baseurl}
-- an AsciiDoc attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
@themr0c, apologies, no |
Hi @rkratky, the PR is rebased against current master. Unfortunately, I didn't manage to get functional links with |
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
…right place Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Includes also additional work on "Configuring a che workspace using a devfile" and "Creating a workspace from code sample" to make them more compatible with modular content.
Add an introduction on "Che quick starts" to have some target for links.