Skip to content

Debounce changes #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdirix opened this issue Sep 30, 2020 · 1 comment · Fixed by #1813
Closed

Debounce changes #1645

sdirix opened this issue Sep 30, 2020 · 1 comment · Fixed by #1813
Labels
core enhancement
Milestone
3.0

Comments

@sdirix
Copy link
Member

sdirix commented Sep 30, 2020

Increase performance by debouncing changes. See also #1641 and lag happening on typing.
@sdirix sdirix added the core label Sep 30, 2020
@sdirix sdirix added this to the 2.5.0 milestone Sep 30, 2020
@sdirix sdirix modified the milestones: 2.5.0, Backlog, next Feb 2, 2021
@sdirix sdirix modified the milestones: next, 3.x, 3.0 May 12, 2021
@sdirix
Copy link
Member Author

sdirix commented Jul 28, 2021 •
edited
Loading

A first iteration could just implement this within the respective renderers, especially text and potential number renderers. One can use lodash debounce for this

eneufeld added a commit to eneufeld/jsonforms that referenced this issue Oct 6, 2021
@eneufeld
Add debounce for input material controls
e3abe6b 
- add a custom hook which handles debounce
- add example to test form performance

Fix eclipsesource#1645
@eneufeld eneufeld mentioned this issue Oct 6, 2021
Merged
eneufeld added a commit to eneufeld/jsonforms that referenced this issue Oct 6, 2021
@eneufeld
Add debounce for input material controls
d307ddd 
- add a custom hook which handles debounce
- add example to test form performance

Fix eclipsesource#1645
eneufeld added a commit to eneufeld/jsonforms that referenced this issue Oct 6, 2021
@eneufeld
Add debounce for input material controls
8a24b09 
- add a custom hook which handles debounce
- add example to test form performance

Fix eclipsesource#1645
sdirix pushed a commit that referenced this issue Oct 8, 2021
@eneufeld
Add debounce for React Material inputs
be5c82c 
Adds a custom hook for debouncing React Material input changes.

This prevents that each keystroke results in a complete rerendering
cycle which can impact perceived performance a lot.

Fix #1645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Add debounce for input material controls eneufeld/jsonforms
1 participant
@sdirix