Skip to content

Empty inputs should result in attribute being deleted #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdirix opened this issue Jul 19, 2022 · 0 comments · Fixed by #1984
Closed

Empty inputs should result in attribute being deleted #1983

sdirix opened this issue Jul 19, 2022 · 0 comments · Fixed by #1984
Assignees
@LukasBoll

Comments

@sdirix
Copy link
Member

sdirix commented Jul 19, 2022

Is your feature request related to a problem? Please describe.

We often save empty strings in the data which is unintuitive behavior and very likely not the effect most users want.

Describe the solution you'd like

  • React Material String
  • React Material Select (autocomplete:off)
  • React Vanilla String
  • React Vanilla Select
  • React Vanilla Number/Integer

Describe alternatives you've considered

Keeping status quo

Framework

React

RendererSet

Material, Vanilla

Additional context

No response
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jul 21, 2022
@LukasBoll
add empty option for enum
957f7fe 
empty input now delete attributes

closes eclipsesource#1983

Signed-off-by: Lukas Boll [email protected]
@LukasBoll LukasBoll mentioned this issue Jul 21, 2022
Merged
sdirix pushed a commit to LukasBoll/jsonforms that referenced this issue Jul 25, 2022
@LukasBoll @sdirix
add empty option for enum
e93f7d1 
empty input now delete attributes

closes eclipsesource#1983

Signed-off-by: Lukas Boll [email protected]
@lmestel lmestel mentioned this issue Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasBoll LukasBoll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deleting Values LukasBoll/jsonforms
2 participants
@sdirix @LukasBoll