Skip to content

React Material Date control breaks once "Clear" is pressed #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukasf opened this issue Feb 10, 2024 · 3 comments · Fixed by #2300
Closed

React Material Date control breaks once "Clear" is pressed #2278

lukasf opened this issue Feb 10, 2024 · 3 comments · Fixed by #2300
Labels
material more information required react
Milestone
3.x

Comments

@lukasf
Copy link
Contributor

lukasf commented Feb 10, 2024

Describe the bug

Once you clear out the value of a date control, the control becomes completely unusable. The date picker does not come up at all.

Expected behavior

When clicking into the date control after its value was cleared, the date picker should come up.

Steps to reproduce the issue

  1. Open the "Control" example
  2. Click on the date to open the picker
  3. Click "Clear"
  4. Now click on the control again. Picker does not come up, no matter what you do.

Screenshots

No response

Which Version of JSON Forms are you using?

v3.2.0

Framework

React

RendererSet

Material

Additional context

This did not occur in 3.1.0.
@sdirix
Copy link
Member

sdirix commented Feb 12, 2024

Hi @lukasf,

Thanks for the report! It seems we broke the control with the improvements we did for #2183.

@sdirix sdirix added this to the 3.3 milestone Feb 12, 2024
@sdirix
Copy link
Member

sdirix commented Feb 12, 2024 •
edited
Loading

@LukasBoll Can you take a look? Let's wait until clarification

@sdirix
Copy link
Member

sdirix commented Feb 12, 2024

@lukasf quick question: When I run the person example, I don't even see a clear button.

image

How does it look like for you?

@sdirix sdirix removed this from the 3.3 milestone Feb 12, 2024
@sdirix sdirix added this to the 3.x milestone Mar 12, 2024
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Mar 12, 2024
@LukasBoll
fix(material): open Date dialog on mobile
9d14782 
closes eclipsesource#2278
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Mar 12, 2024
@LukasBoll
fix(material): open date dialog on mobile
90e9b81 
closes eclipsesource#2278
@LukasBoll LukasBoll mentioned this issue Mar 12, 2024
Merged
sdirix pushed a commit that referenced this issue Mar 18, 2024
@LukasBoll
fix: render date modal in React Material on mobile clients
3e9ba1f 
Keep track of the open state manually in React Material date pickers.
This avoids resetting the open state when changing the picker "key".

fixes #2278
@LukasBoll LukasBoll mentioned this issue Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
material more information required react
Projects
None yet
Milestone
3.x
Development

Successfully merging a pull request may close this issue.

fix(material): open date dialog on mobile LukasBoll/jsonforms
3 participants
@lukasf @sdirix @LukasBoll