We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This a list of type names, which I think could be improved upon:
isRelevantKey
needsNotificationAbout
initialRootRun
initDataChangeListeners
notifyChange
notifyDataChangeListeners
dataChanged
notify
runtimeChanged
inputElement
createInputElement
JsonFormsHolder
JsonForms
JsonFormsElement
Renderer
Consistency-related issues
UISchemaElement
UiSchemaTester
UiSchemaRegistry
UISchemaRegistry
getBestUiSchema
findMostApplicabeUISchema
register
deregister
The text was updated successfully, but these errors were encountered:
Fixes eclipsesource#580
5f7472c
* Update and streamline methods names * Update test descriptions
0bbefbd
e763ba3
743966c
13aed85
No branches or pull requests
This a list of type names, which I think could be improved upon:
isRelevantKey
->needsNotificationAbout
?initialRootRun
->initDataChangeListeners
notifyChange
->notifyDataChangeListeners
notifyChange
(same name as DataService) ->dataChanged
?notify
->runtimeChanged
inputElement
->createInputElement
as the contract seems to be to return a new element on each invocation, do not model as propertyJsonFormsHolder
toJsonForms
JsonForms
toJsonFormsElement
(as the actual element name does not matter much anyways)JsonForms
has almost same methods as aRenderer
. Try to unify both types, if not possible rename methods inJsonForms
to resemble those ofRenderer
Consistency-related issues
UISchemaElement
vsUiSchemaTester
/UiSchemaRegistry
etc.UISchemaRegistry
:getBestUiSchema
->findMostApplicabeUISchema
register
/deregister
-> follow-up issue Services should use common naming scheme for listeners registration #583The text was updated successfully, but these errors were encountered: