Skip to content

Namings #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edgarmueller opened this issue Jun 7, 2017 · 0 comments
Closed

Namings #580

edgarmueller opened this issue Jun 7, 2017 · 0 comments

Comments

@edgarmueller
Copy link
Contributor

edgarmueller commented Jun 7, 2017

This a list of type names, which I think could be improved upon:

  • DataService: isRelevantKey -> needsNotificationAbout?
  • DataService: initialRootRun -> initDataChangeListeners
  • DataService: notifyChange -> notifyDataChangeListeners
  • DataServiceListener: notifyChange (same name as DataService) -> dataChanged?
  • RuntimeListener: notify -> runtimeChanged
  • BaseControl: inputElement -> createInputElement as the contract seems to be to return a new element on each invocation, do not model as property
  • Rename JsonFormsHolder to JsonForms
  • Rename JsonForms to JsonFormsElement (as the actual element name does not matter much anyways)
  • JsonForms has almost same methods as a Renderer. Try to unify both types, if not possible rename methods in JsonForms to resemble those of Renderer

Consistency-related issues

@edgarmueller edgarmueller added this to the 2.0.0-Alpha-5 milestone Jun 7, 2017
edgarmueller added a commit to edgarmueller/jsonforms that referenced this issue Jun 14, 2017
* Update and streamline methods names
* Update test descriptions
edgarmueller added a commit to edgarmueller/jsonforms that referenced this issue Jun 14, 2017
* Update and streamline methods names
* Update test descriptions
edgarmueller added a commit to edgarmueller/jsonforms that referenced this issue Jun 14, 2017
* Update and streamline methods names
* Update test descriptions
edgarmueller added a commit to edgarmueller/jsonforms that referenced this issue Jun 14, 2017
* Update and streamline methods names
* Update test descriptions
edgarmueller added a commit to edgarmueller/jsonforms that referenced this issue Jun 19, 2017
* Update and streamline methods names
* Update test descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant