Skip to content

Update of JSON schema definitions #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edgarmueller
Copy link
Contributor

@edgarmueller edgarmueller commented Jun 6, 2018

Fixes issues #856 #938, and #998.
Make JsonSchema a union type of JsonSchema4 and newly introduced JsonSchema7. Update validator accordingly to use option auto which also solves issue #998. Some things to note:

  • The schema generator needs to known about the generated version, hence it keeps using v4 for now
  • The editor is due its usage of id specific to v4

Further improvements (e.g. supporting additional keywords) and refactoring (editor component) should be handled in separate issues, such that we can close #856 .

@edgarmueller edgarmueller changed the title Update of JSON schema definitions (#938) Update of JSON schema definitions Jun 6, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.69% when pulling df362f9 on edgarmueller:topic/update-schema-version into 24fdf60 on eclipsesource:master.

@edgarmueller edgarmueller requested a review from eneufeld June 6, 2018 16:34
@edgarmueller edgarmueller merged commit 637f67c into eclipsesource:master Jun 7, 2018
@edgarmueller edgarmueller added this to the 2.0.2 milestone Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examine schema version 7 for JSONForms
3 participants