Skip to content

Add schema based condition #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2018
Merged

Add schema based condition #1024

merged 2 commits into from
Jul 13, 2018

Conversation

edgarmueller
Copy link
Contributor

Adds a new 'SchemaBasedCondition' condition type

@coveralls
Copy link

coveralls commented Jul 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 88.254% when pulling 6688f69 on edgarmueller:topic/schema-condition into 62478b0 on eclipsesource:master.

@edgarmueller edgarmueller requested a review from eneufeld July 12, 2018 15:02
eneufeld
eneufeld approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two very small nitpicks,
awesome feature otherwise

packages/core/src/util/runtime.ts Outdated

const isSchemaCondition = (condition: Condition): condition is SchemaBasedCondition =>
condition.type === undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check for the schema attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, fixed

packages/core/src/util/runtime.ts

return true;
switch (uischema.rule.effect) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we unify the formatting for evalVisibility and evalEnablement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@edgarmueller edgarmueller merged commit 0e5f41b into eclipsesource:master Jul 13, 2018
@edgarmueller edgarmueller added this to the 2.0.6 milestone Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @eneufeld