Skip to content

Port slider renderer to material-ui #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2018
Merged

Port slider renderer to material-ui #1025

merged 1 commit into from
Jul 13, 2018

Conversation

mathansen
Copy link

@mathansen mathansen requested a review from edgarmueller July 12, 2018 16:10
@mathansen mathansen mentioned this pull request Jul 12, 2018
Closed
@mathansen
Copy link
Author

Test case for multipleOf missing. Will submit it tomorrow.

Port slider renderer to material-ui
9874bc1 
* Introduces dependency to mui/lab as the slider is not included in mui/core
* Refactor existing slider field to control
* Adapt tests
* Fixes eclipsesource#583
@mathansen
Copy link
Author

Added the check for multipleOf (verifies that the step size is set correctly).

edgarmueller
edgarmueller approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we could improve a bit by displaying the current value and removing some linter issues, but I'll take care of that myself.

@edgarmueller edgarmueller merged commit 2321755 into eclipsesource:master Jul 13, 2018
@edgarmueller edgarmueller mentioned this pull request Jul 13, 2018
Closed
@mathansen mathansen deleted the issue/853 branch July 13, 2018 10:11
@edgarmueller edgarmueller added this to the 2.0.6 milestone Jul 13, 2018
@Schloemicher Schloemicher mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mathansen @edgarmueller