Skip to content

Conversation

awnawab
Copy link
Collaborator

@awnawab awnawab commented Sep 12, 2025

A small bugfix PR that removes unused symbols and imports from FIELD_DEFAULTS_MODULE and should fix the problems reported in #111.

@awnawab awnawab requested review from dareg and mlange05 September 12, 2025 10:06
@awnawab
Copy link
Collaborator Author

awnawab commented Sep 12, 2025

FYI @dhaumont.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@dhaumont
Copy link

dhaumont commented Sep 12, 2025

Did you try to recompile IFS with these changes?
I did with IAL and it is will not compile anymore, due to some missing declarations (gfortran compiler, single precision)

@awnawab
Copy link
Collaborator Author

awnawab commented Sep 12, 2025

Did you try to recompile IFS with these changes? I did with IAL and it is will not compile anymore, due to some missing declarations (gfortran compiler, single precision)

Yes I've just successfully built IFS in DP with nvhpc 24.5 and in SP with GNU 14.2 with the current f-api branch, didn't experience any issues. Could you please try using this branch with IAL and see if it solves your problem?

@awnawab
Copy link
Collaborator Author

awnawab commented Sep 19, 2025

Hi @dhaumont,

I didn't know that INIT_DEBUG_VALUE_JPRB was being used outside of field_api in IAL, that's why I thought it would be safe to remove. I am happy to restore it and instead compile field_defaults_module for each precision. Please let me know how you would like me to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants