Skip to content

HDF5 IO with Fiat and MPI independent option (over main) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

HDF5 IO with Fiat and MPI independent option (over main) #119

wants to merge 6 commits into from
+138 −74

Conversation

piotrows
Copy link
Contributor

@piotrows piotrows commented Sep 29, 2025 •
edited
Loading

This PR (copy of 116) brings the following changes

  • removes dependence on MPL and replaces it with MPI dependence
  • removes dependence of tests on Fiat, except for two tests
  • introduces ENABLE_MPI option to explicitly request linking of MPI
  • introduces serial and parallel IO option to make IO independent of MPI in the former and enforce MPI presence in the latter
  • CI now tests parallel IO HDF5 write option

Minor technical changes:

  • ecbuild version bump to work with the actual cmake on Mac/brew
  • CI Mac versions bump to ensure that MPI is properly detected

Corresponding example of use in CLOUDSC PR:
ecmwf-ifs/dwarf-p-cloudsc#121

@piotrows piotrows force-pushed the napz-IO-fiat-mpi-independent_main_staged branch 2 times, most recently from fc6c4f7 to 282f6aa Compare September 29, 2025 18:05
awnawab
awnawab approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@awnawab awnawab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many many thanks for this @piotrows 🙏 This looks fantastic now, I really like it 👌 I just left one nitpicky comment, and of course it would be nice to update the Readme once this is turned into a full PR.

mlange05
mlange05 approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@piotrows piotrows marked this pull request as ready for review October 6, 2025 18:18
@piotrows piotrows force-pushed the napz-IO-fiat-mpi-independent_main_staged branch from 5a0e35d to 16996a7 Compare October 6, 2025 18:22
@piotrows piotrows force-pushed the napz-IO-fiat-mpi-independent_main_staged branch from 16996a7 to 1af5534 Compare October 6, 2025 18:30
@piotrows piotrows requested a review from dareg October 7, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlange05 mlange05 mlange05 approved these changes

@awnawab awnawab awnawab approved these changes

@dareg dareg Awaiting requested review from dareg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrows @mlange05 @awnawab