This repository was archived by the owner on Feb 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 260
Remove Export Services for Geneva Release #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: edgexfoundry/edgex-go#2218 Signed-off-by: Michael W. Estrin <[email protected]>
lenny-goodell
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will same be done for BlackBox tests? How are we going to archive the export services since that are in the mono repo? |
Working my way through the repositories. Started with developer-scripts first. Code will be removed from edgex-go master; will still existing in prior release's branches. |
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 10, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 10, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 10, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 10, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
tingyuz
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 11, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 12, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 15, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 15, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to michaelestrin/edgex-go
that referenced
this pull request
Dec 16, 2019
Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: edgexfoundry#2218 Signed-off-by: Michael Estrin <[email protected]>
michaelestrin
added a commit
to edgexfoundry/edgex-go
that referenced
this pull request
Dec 18, 2019
* Remove Export Services for Geneva Release Dependencies on: - edgexfoundry/developer-scripts#186 - edgexfoundry/blackbox-testing#346 - edgexfoundry/go-mod-core-contracts#186 Post-merge of edgexfoundry/go-mod-core-contracts#186, this PR should be updated to reflect the new version of go-mod-core-contracts. Fixes: #2218 Signed-off-by: Michael Estrin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: edgexfoundry/edgex-go#2218
Signed-off-by: Michael W. Estrin [email protected]