python2/3 compatibility and pip package #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require at least v0.14.0 of future. Added travis config.
…n Python. The original Python code simply copies the structure of the original JS code. However, the JS code only works, because at the end of the array, when it increases the data.index value beyond its length, the str.charCodeAt(index) function returns NaN. The not value is in the next iteration combined using bitewise AND operator with data.position to produce numerical 0. This change reproduces this ingenious /s JS behaviour in Python.
Fixes decompression of base64 strings originated from JS compressor i…
Added MANIFEST.in file for PyPI packaging of licence and readme.
…string-python which better matches recent versions of lzstring
compressToUint8Array decompressToUint8Array This is the best I could do without doing a bigger rewrite so lzstringn doesn't use the str() type and use bytes() (or another type). str() have lot of issues with conversions.
Implement Uint8 encoding/decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uploaded the resulting package to https://pypi.python.org/pypi/lzstring/ - let me know your pip username so I can give ownership to you.